2,085 Tests, and None of Them Opens the Front Door

(i.brandanthonymcdonald.com)

4 points | by aweful 3 days ago

6 comments

  • simonreiff 1 hour ago
    "The honest summary is that a plain-English end-to-end layer would fill a real and currently empty tier, sitting on top of roughly two thousand fast deterministic tests doing work no browser tool can do. Both halves of that sentence are load-bearing. A vendor who only says the first half is telling me they have not read a codebase like mine."

    A person who posts an article like this is telling me they have neither written nor read their article. Or their own code base, for that matter. So this person had problems in a code base he didn't write, didn't read either, it seems, and now wants all of us to read an article about this zombie code base, except he also didn't write or read over that article before posting it.

    To the author: Your article can be rewritten in a few sentences like this: "I vibe coded a code base and asked Claude to add tons of unit tests. I didn't read the code or the tests; just wanted it to work. But I either didn't know to ask to wire the tests into my CI/CD pipeline, didn't know what that was, or did know but was too lazy to check that it happened. Anyway, I sure learned my lesson: What happens in localhost:3000 stays in localhost:3000. Gotta wire up your .github/workflows/cicd.yml file to pull in your tests. Otherwise it really doesn't do much for you. Lesson learned!" And you know what? As banal as that would have been, I would have enjoyed that article so much more. Just take 5 minutes man. Five freaking minutes.

  • perrygeo 3 days ago
    Anecdote time: I worked on a project with a senior dev who was really into unit testing and only unit testing. The software had to be fully tested as tiny little lego bricks with mocks galore. Because "if all the pieces were correct, the combination had to be correct" - his words. (I guess he'd never considered emergent behavior)

    I'll never forget the cycle, after staunch objections to integration/e2e/manual tests and zealously insisting on full unit test coverage, the senior dev deployed changes ... boom. The process failed hard minutes after start because there was a bug in main. Full production outage. A bug so obvious we should have caught it by eye. Clearly, in the weeks developing the feature, he had never bothered to even run the application. Each part was fully polished in isolation but utterly failed when integrated into an application.

    The way I've come to think of it: Unit tests are for libraries, a closed world where you can neatly define all inputs and outputs. Integration/E2E tests are for applications, an open world which require systems thinking, simulations not proofs. Know which world you're working in!

    • ad_fontes 3 hours ago
      That doesn't really sound like an indictment of unit tests. I don't really understand why someone would meticulously write a bunch of unit tests and then wait to prove them on a production deploy?

      Unit and integration tests serve different purposes and one isn't necessarily better than the other.

      • simonw 3 hours ago
        It's an indictment of writing only unit tests. If the system also had integration tests this would likely have been caught, but even more important is the lesson that no amount of automated tests is an excuse not to actually try using your software yourself.
    • LoganDark 3 hours ago
      Both is good.
  • netsharc 3 hours ago
    Skimmed through this. One heading is "The gap was never coverage. It was wiring.". Smeḷls very AI sloppy, won't bother reading...

    I used to read anything and everything on HN, but my allergy to slop has made me stop doing that. I suppose that's a good thing?

    • simonw 3 hours ago
      I had to paste this into Claude and ask it to filter out the core idea. Here's the most important paragraph quoted from the article:

      > The one repository with working CI has a workflow file of about 40 lines that runs a type check, the test suite, and a build on every pull request. Sixteen other repositories use the same test runner. Copying it sideways is an afternoon.

      So I think they're saying that they never wired up CI, and as a result the value provided by their test suite in preventing bad code from shipping is limited.

    • Scramblejams 2 hours ago
      My antennae were twitching early on, it was "That is a floor, not a total" that flipped the switch for me and I closed the piece.

      I'm developing a distracting hypervigilance that kicks in whenever I start reading anything linked from here or lobsters or LinkedIn. Instead of focusing on whatever it's saying, I'm looking for the tells instead.

      I hate what AI's doing to reading. It's like when the desktop publishing revolution reached folks who never could have put together a decent banner to save their lives, and suddenly chintzy Broderbund Print Shop-generated examples were hanging in every classroom. But at least that was limited to peeps who had access to a dot matrix printer and scads of tractor feed paper. Now clankers write for everybody who either can't write or won't put in the time, and the low-effort slop is everywhere.

      It'd be one thing if they used AI to write a draft and then rewrote it to make it theirs. I'd read it! But they can't be bothered. Very unfortunate, and I refuse to waste my time on it.

      Just post the prompt you used, Brand, I'd probably get more value...

  • KenPainter 3 days ago
    Your Website seems to be messing with browser history. Back button will not take you back to HN.
  • lloydatkinson 2 hours ago
    > Opens the front door

    This is the most recent AI slop phrase the models produce, keep an eye out you'll see it everywhere.

    • torton 1 hour ago
      This might be so but I thought it refers to an ancient QA joke:

      > A QA engineer walks into a bar. Orders a beer. Orders O beers. Orders 99999999999 beers. Orders a lizard. Orders -1 beers. Orders a ueicksjdhd.

      > First real customer walks in and asks where the bathroom is. The bar bursts into flames, killing everyone.

  • aweful 3 days ago
    [dead]