git's –end-of-options Flag

(nesbitt.io)

57 points | by Erenay09 1 day ago

8 comments

  • metadat 1 hour ago
    Does anyone know why git broke the long standing convention of "--" early on? Kind of a nightmare for humans to use.

    Remembering app-specific one-offs is kind of the worst!

    • doctoboggan 59 minutes ago
      git's data model is incredibly powerful and flexible, but its UX is famously... interesting:

      https://stevelosh.com/blog/2013/04/git-koans/

    • epistasis 35 minutes ago
      Since it separates out the pathspec, doesn't that match the long standing convention?
    • p-e-w 54 minutes ago
      When something appears to be poorly designed, then the deeper explanation is often that it’s indeed poorly designed.
  • epistasis 38 minutes ago
    Perhaps I'm missing something (it's been a long day), but couldn't "--" be used for both?

        git cmd --options -- rev -- pathspec
    
    would be the fully specified revspec and pathspec

        git cmd --option -- rev --
    
    would be just the revspec, excluding accidental options, without a pathspec

        git cmd --option revspec -- pathspec
    
    and the single "--" would work as it currently does.
    • gene91 6 minutes ago
      Currently, git log -- a -- prints all commits that affects the files whose name is a or two dashes.
  • js2 6 minutes ago
    Folks who didn't click through to the commit[^1] may be missing this reasoning:

    > The name is verbose, but that's probably a good thing; this is meant to be used for scripted invocations where readability is more important than terseness.

    That reasoning makes sense to me. In over a decade of using git, I've never had a case where I'd need to disambiguate a ref that could be confused as an option. And if I did I'd know the ref name so I'd use its full path: `refs/head/--whatever` (just like with `rm` where I prefer `rm ./--whatever` over `rm -- --whatever`).

    So yes, this is oddly named, but it was retrofitted so options were limited and it's fine for its intended use case.

    (But sure, go ahead HN and use this as yet another post where you can gripe about git's UI. Or tell us how much better jj is. It's boring conversation though.)

    [^1]: https://github.com/git/git/commit/19e8789b236dfe33667747d552...

  • yobert 1 hour ago
    So I should name my next branch ‘--‘ is what I'm hearing :)
    • fragmede 35 minutes ago
      [flagged]
      • randunel 15 minutes ago
        That's still the default in my localhost, but I get a warning that it'll change.
  • Chinjut 11 minutes ago
    The "Everything is text, do everything via text" philosophy has its advantages, and also its disadvantages.
  • bradley13 43 minutes ago
    As with almost any successful system: more and more special features and edge cases get added. Git has become ridiculously complex.

    I wonder: would it not be better to tell users with those edge cases to fix their problems some other way? To take an example from the article: why does someone have a filename beginning with a dash? Maybe don't do that.

    • zanecodes 30 minutes ago
      Sometimes you're using git in a context where you don't control the filenames, or where a potential attacker could influence or fully control them, at which point edge cases like this can easily turn into exploits.

      I also chafe whenever I run into artificial restrictions on things like characters in names of things, because there's no good reason for them besides the laziness of developers or the limitations and inertia of existing systems that might be used under the hood, like DNS for instance.

  • _blk 56 minutes ago
    > git log --end-of-options "$rev" -- "$path",

    Argh, that's when I wished for object oriented shells. Powershell sure isn't perfect but objects encoding their own meaning really helps differentiate those cases (but it may not always help the user if types aren't clear to the reader)

    • eru 49 minutes ago
      I don't think you need object orientation for that. Haskell and Rust solve these problems also just fine, without any OOP in sight.
      • _blk 24 minutes ago
        Hmm, not sure I understand. How are those shell based?

        I agree that rust and haskell are not your typical OO (or not OO at all in a traditional sense) I guess my poorly worded claim was less focused on the OO nature of psh than on the typization (which both of these also do) - if you knew what type $rev and $path are, it's easier to distinguish intent, whether objects or not.

  • ButlerianJihad 47 minutes ago
    https://m.xkcd.com/1597/

    By the way, something munched the article title. An emdash is incorrect command-line usage. It’s supposed to be a double hyphen.

    • wafflemaker 41 minutes ago
      From the title I've learned that git uses an em-dash instead of double dash as options delimiter. Thanks for pointing out that the title was wrong -- I've never had a need to use -- with git, so didn't know that it doesn't work.